SP-1090: Assert on real process output and exit codes in integration tests#375
Open
A. Jashari (admirjashari) wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Changes
module-handler.ts: the shared command action wrapper now setsprocess.exitCode = 1when a command throws, so errors surface as a non-zero exit code (previously thrown errors were only logged and the process still exited0).GracefulErroris preserved as exit0.package.manager.ts: fixed a bareprocess.exit()(exited0) on an error branch →process.exit(1).Tests Added
tests/utls/cli-runner.ts(runCli), which drives a command through the real Commander wiring and captures the actualstdout,stderr, and exit code.tests/integration/cli-process-output.spec.tsasserting real output + exit codes for success and failure cases (asset-registry as the agentic-dev surface, plus version/unknown-command/required-option, and the GracefulError vs. regular-error exit-code contract).Relevant links
Checklist