fix: keep icon button content centered#5014
Open
vivekjm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4829.
This changes the IconButton ripple content from
flexGrow: 1toflex: 1so the pressable content reliably fills the fixed-size container before centering the icon. That keeps the icon centered when callers add custom container styles such as a background color.Test plan
yarn test src/components/__tests__/IconButton.test.tsx --runInBandyarn lintyarn typecheckyarn test -uupdated snapshots affected by the shared IconButton style. The full run otherwise passes exceptsrc/babel/__tests__/index.js, which cannot start because this checkout does not havelib/mappings.jsongenerated andyarn generate-mappingspoints to a missingscripts/generate-mappings.tsfile.