Skip to content

fix(layering): unblock main — raise the daemon-server R9 ceiling for #1779's snapshot interactor seam #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thymikee wants to merge 1 commit into from
Closed

fix(layering): unblock main — raise the daemon-server R9 ceiling for #1779's snapshot interactor seam #1835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/layering/daemon-modularity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ test('daemon modularity baseline records the measured R7 ownership pressure', ()
Object.values(SESSION_STATE_FIELD_OWNERS).reduce((sum, owners) => sum + owners.length, 0),
DAEMON_MODULARITY_BASELINE.sessionState.ownerFileClaims,
);
assert.equal(TYPE_CYCLE_BASELINE, 46);
assert.equal(DAEMON_MODULARITY_BASELINE.largestTypeCycle.zoneMembers['daemon-server'], 16);
assert.equal(TYPE_CYCLE_BASELINE, 47);
assert.equal(DAEMON_MODULARITY_BASELINE.largestTypeCycle.zoneMembers['daemon-server'], 17);
assert.equal('daemon' in DAEMON_MODULARITY_BASELINE.largestTypeCycle.zoneMembers, false);
});

Expand Down Expand Up @@ -230,6 +230,6 @@ test('R9 rejects a baseline left above the measured cycle', () => {

assert.equal(violations.length, 1);
assert.match(violations[0]!.rule, /^R9 /);
assert.match(violations[0]!.message, /dropped to 45 files \(baseline 46\)/);
assert.match(violations[0]!.message, /dropped to 46 files \(baseline 47\)/);
assert.match(violations[0]!.message, /Lower LARGEST_TYPE_CYCLE_ZONE_CEILINGS by the same 1/);
});
4 changes: 3 additions & 1 deletion scripts/layering/daemon-modularity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ const LARGEST_TYPE_CYCLE_ZONE_CEILINGS: Readonly<Record<string, number>> = {
client: 1,
commands: 14,
core: 10,
'daemon-server': 16,
// 17 since d76e0f94e (#1779): snapshot-capture.ts -> handlers/snapshot-interactor-capture.ts ->
// core/interactors.ts wedges the new interactor seam between two members, so it joins the cycle.
'daemon-server': 17,
platforms: 2,
};

Expand Down
Loading