docs(web): consolidate responsive breakpoints into a documented scale#277
Merged
Merged
Conversation
The signed-in shell carried four ad-hoc breakpoint values across three stylesheets (680/681, 1080, 560) kept in sync only by scattered comments. Add a single documented breakpoint scale in signed-in-shell.css and reference each media query by name (--bp-stack / --bp-rail / --bp-file-grid). Comment-only: no media query or pixel value changes. Closes #276.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
uploads-web | b3e0b8d | Commit Preview URL Branch Preview URL |
Jul 19 2026, 11:32 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #276.
The signed-in shell carried four ad-hoc breakpoint values across three stylesheets, kept in sync only by scattered per-query comments:
account-shell.css+signed-in-shell.css)account-shell.css)account-content.css)The #274 review flagged that a third responsive surface already exists, so this introduces the documented breakpoint scale that follow-up called for.
What changed
signed-in-shell.cssnaming the three boundaries —--bp-rail(1080),--bp-stack(680),--bp-file-grid(560) — with the rationale for the 680/681 adjacency in one place.Media queries can't read CSS custom properties and the app has no PostCSS pipeline, so the scale is documentation (not
--bp-*variables) per the option the issue sanctioned — a note in the block warns against defining them as variables that would silently fail in a media query.Comment-only — no media query conditions or pixel values changed, so rendering is identical.