Handle non-ASCII characters in STEP files - #320
Draft
Ghesselink wants to merge 1 commit into
Draft
Conversation
- Decode ISO 10303-21 string escapes (\X2\..\X0\, \X4\, \X\, \S\, \P?\) when reading the header, so company/application names are stored and shown decoded instead of as raw escape sequences - Never expose raw subprocess stderr as a syntax outcome: translate the parser's UnicodeDecodeError into a user-facing message with the correct line/column and a hint about \X2\ escapes - Recompute the reported position for non-ASCII characters from the actual file; the header-only parser reports the wrong line - Resolve the renamed simple_spf parse-error class so header parse failures land in "syntax_error" again - Add fixtures and tests for raw UTF-8, latin-1 and \X2\-escaped headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My WIP, feel free to use it @rw-bsi :)