Skip to content

fix: tool prompt behavior#220

Merged
frostming merged 3 commits into
bubbuild:mainfrom
tommy0103:fix/tui-and-tools
Jun 3, 2026
Merged

fix: tool prompt behavior#220
frostming merged 3 commits into
bubbuild:mainfrom
tommy0103:fix/tui-and-tools

Conversation

@tommy0103
Copy link
Copy Markdown
Contributor

@tommy0103 tommy0103 commented May 31, 2026

Summary

  • Render tool parameter signatures in the tool prompt so models get clearer argument guidance.
  • Resolve allowed tool names through both runtime names and model-facing aliases.
  • Keep model tool schemas unchanged while still rewriting dotted tool names for model calls.
  • Make tool-name tests independent of builtin registry import side effects.

Verification

  • env UV_CACHE_DIR=/private/tmp/uv-cache uv run ruff check --no-fix src tests
  • env UV_CACHE_DIR=/private/tmp/uv-cache uv run mypy src
  • env UV_CACHE_DIR=/private/tmp/uv-cache uv run pytest -q

@frostming
Copy link
Copy Markdown
Collaborator

Hi, I've simplified the CLI renderer to fix the streaming issue, can you update your PR to exclude that change?

Resolve allowed tool names through the registry so model-facing aliases map back to runtime tool names. Pass the filtered tool set into the system prompt and include parameter signatures in rendered tool listings.
@tommy0103 tommy0103 force-pushed the fix/tui-and-tools branch from b809772 to da2608a Compare June 2, 2026 09:26
@tommy0103
Copy link
Copy Markdown
Contributor Author

Hi, I've simplified the CLI renderer to fix the streaming issue, can you update your PR to exclude that change?

Done. I've updated the PR

@tommy0103 tommy0103 changed the title fix: tighten CLI streaming and tool prompt behavior fix: tool prompt behavior Jun 2, 2026
@frostming
Copy link
Copy Markdown
Collaborator

There is a ruff format issue left. You can run prek run -a to fix it locally.

@tommy0103
Copy link
Copy Markdown
Contributor Author

Thanks! I’m still getting used to Ruff/prek, appreciate the heads-up.

@frostming frostming merged commit 89f461e into bubbuild:main Jun 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants