cleanup: Combine duplicated code in Client#query and avoid unneeded early non-const declarations#3674
Merged
Conversation
… early non-const declarations No behaviour change except for the negligible one of reading the `query_timeout` property before `submit`.
There was a problem hiding this comment.
Pull request overview
Refactors Client#query to deduplicate the readTimeout assignment across the two config branches and switches early-declared let variables to const declarations at their point of use. No behavioral change other than query_timeout now being read unconditionally (including for submittable query objects, which was previously also the case via the other branch).
Changes:
- Collapse the
null/undefinedcheck intoconfig == null. - Hoist the
readTimeoutresolution out of both branches into a singleconst. - Convert
queryCallbackandreadTimeoutTimerfrom outerlets to innerconsts within theif (readTimeout)block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charmander
added a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behaviour change except for the negligible one of reading the
query_timeoutproperty beforesubmit.