Skip to content

Use explicit int32 for all the integer variables and coordinates - #207

Merged
alexamici merged 1 commit into
mainfrom
bugfix/explicit-int32-dtypes
Nov 15, 2026
Merged

alexamici merged 1 commit into
mainfrom
bugfix/explicit-int32-dtypes

Conversation

@alexamici

@alexamici alexamici commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

The line, pixel, degree and count values and the noise azimuth first and last line and sample used the platform default integer, int64 on 64-bit and int32 on 32-bit architectures. Set them to int32 everywhere, as the CPM 3.0 mapping does for line, pixel and the noise azimuth values; it leaves degree and count undeclared.

Drop the 32-bit xfails added in #203, the dtypes no longer depend on the architecture.

Thanks to @avalentino for testing on 32bits architectures and helping keep the code clean.

The line, pixel, degree and count values and the noise azimuth first and
last line and sample used the platform default integer, int64 on 64-bit
and int32 on 32-bit architectures. Set them to int32 everywhere, as the
CPM 3.0 mapping does for line, pixel and the noise azimuth values; it
leaves degree and count undeclared.

Drop the 32-bit xfails added in #203, the dtypes no longer depend on
the architecture.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alexamici
alexamici merged commit 3bd97be into main Nov 15, 2026
10 checks passed
@alexamici
alexamici deleted the bugfix/explicit-int32-dtypes branch November 16, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant