Repository navigation
Remove /boost/xpressive//boost_xpressive dependency - #277
Merged
Merged
Conversation
It's only used by the samples. Boostdep scans the sources and possibly tests and will miss this if not explicitely asked to include samples which may not be generally desired and leads to uneccessary failures.
Member
|
The library dependencies in build.jam should not include test or example dependencies. These should go into the appropriate test or example Jamfiles. |
Contributor
Author
|
Andy they actually are there already: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #277 +/- ##
==========================================
Coverage ? 33.90%
==========================================
Files ? 76
Lines ? 7391
Branches ? 4105
==========================================
Hits ? 2506
Misses ? 2369
Partials ? 2516 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks! I appreciate the help. |
jefftrull
pushed a commit
that referenced
this pull request
Oct 26, 2026
It's only used by the samples. Boostdep scans the sources and possibly tests and will miss this if not explicitely asked to include samples which may not be generally desired and leads to uneccessary failures.
jefftrull
pushed a commit
that referenced
this pull request
Oct 26, 2026
It's only used by the samples. Boostdep scans the sources and possibly tests and will miss this if not explicitely asked to include samples which may not be generally desired and leads to uneccessary failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's only used by the samples.
Boostdep scans the sources and possibly tests and will miss this if not explicitely asked to include samples which may not be generally desired and leads to uneccessary failures.
Issue introduced in #267
cc @jefftrull