Repository navigation
Enable setting language standard C++26 - #276
Merged
jefftrull merged 2 commits intoOct 26, 2026
Merged
Conversation
boost.wave is not yet able to preprocess C++26 specific features like `#embed`. However, using the C++26 language mode allows preprocessing code which requires `__cplusplus` to be set according to C++26. Also, adding the boilerplate now makes it easier add later support for the C++26 specific language features.
While adding C++26 support we realized cpp_macromap has an existing bug in C++23 mode. When using C++23 `BOOST_WAVE_SUPPORT_CPP2A` would be true, but `need_cpp2a()` is false (also `need_cpp26` would be false now that we added it). That means, we would not enter branches we are supposed to go into. Adding an additional `need_cpp2b()` into the ro chains fixes this bug.
4 tasks done
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #276 +/- ##
==========================================
Coverage ? 33.92%
==========================================
Files ? 76
Lines ? 7419
Branches ? 4121
==========================================
Hits ? 2517
Misses ? 2375
Partials ? 2527 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thank you for the helpful contribution! |
jefftrull
pushed a commit
that referenced
this pull request
Oct 26, 2026
* Enable setting language standard C++26 boost.wave is not yet able to preprocess C++26 specific features like `#embed`. However, using the C++26 language mode allows preprocessing code which requires `__cplusplus` to be set according to C++26. Also, adding the boilerplate now makes it easier add later support for the C++26 specific language features. * Fix logic bug in macromap for C++23 While adding C++26 support we realized cpp_macromap has an existing bug in C++23 mode. When using C++23 `BOOST_WAVE_SUPPORT_CPP2A` would be true, but `need_cpp2a()` is false (also `need_cpp26` would be false now that we added it). That means, we would not enter branches we are supposed to go into. Adding an additional `need_cpp2b()` into the ro chains fixes this bug.
jefftrull
pushed a commit
that referenced
this pull request
Oct 26, 2026
* Enable setting language standard C++26 boost.wave is not yet able to preprocess C++26 specific features like `#embed`. However, using the C++26 language mode allows preprocessing code which requires `__cplusplus` to be set according to C++26. Also, adding the boilerplate now makes it easier add later support for the C++26 specific language features. * Fix logic bug in macromap for C++23 While adding C++26 support we realized cpp_macromap has an existing bug in C++23 mode. When using C++23 `BOOST_WAVE_SUPPORT_CPP2A` would be true, but `need_cpp2a()` is false (also `need_cpp26` would be false now that we added it). That means, we would not enter branches we are supposed to go into. Adding an additional `need_cpp2b()` into the ro chains fixes this bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #263
boost.wave is not yet able to preprocess C++26 specific features like
#embed.However, using the C++26 language mode allows preprocessing code which requires
__cplusplusto be set according to C++26. Also, adding the boilerplate now makes it easier add later support for the C++26 specific language features.This contribution also fixes an already existing bug in the second commit.
We realized cpp_macromap has an existing bug in C++23 mode. When using C++23
BOOST_WAVE_SUPPORT_CPP2Awould be true, butneed_cpp2a()is false (alsoneed_cpp26would be false now that we added it). That means, we would not enter branches we are supposed to go into. Adding an additionalneed_cpp2b()into the or chains fixes this bug.