Windows CI: Exit workflow on any errors; fix vcpkg caching

[stephengtuggy]

Fixes #521 (hopefully).

Fixes #523 .

[stefanseefeld]

Can you explain the change ? It looks to me like you merely replaced cmd by pwsh and changed the commands accordingly. How does that affect the caching ?

[stephengtuggy]

Can you explain the change ? It looks to me like you merely replaced cmd by pwsh and changed the commands accordingly. How does that affect the caching ?

Yes, I can explain. The cache save step was failing with an error that the paths given did not exist -- even though they did. Removing the quotes from the paths fixed that. The cache save step is now succeeding, and at least some of the time, the cache restore step is now also succeeding, because there is a cache entry to retrieve.

I also fixed the cache key calculation, which was incorrect. I originally copy-pasted it from one of my other repositories, and it included some matrix parameters that are not valid in this repository. That is now fixed.

The other changes may or may not be relevant. As you said, I changed the shell used to PowerShell, and changed the commands accordingly. I have a little bit more confidence that PowerShell will actually fail the build if a test fails, vs. cmd.exe. But I'm not 100% sure that it really makes a difference.

[stefanseefeld]

OK, but the two shell changes (from cmd to pwsh in the build and test steps) are unrelated and not needed, yes ?