Repository navigation
Conversation
The unit was only looked up when the translated action.preview_secure_share label was translated again by macro.buttonlink(). That double translation is fixed in 6.1, so the unit is no longer used.
The login-required flash message is now added as an untranslated key and translated by _flash_messages.html.twig in the "messages" domain, like the other backend flash messages, instead of in "security". Move its units from security.*.xlf to messages.*.xlf for cs, de, en, fr, nl, ru and sk, keeping the wording, so the message users see does not change.
Vondry
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translation part of #3834 (reverted in #3842), made for 6.2. The code changes are in #3843 for 6.1.
_flash_messages.html.twigin themessagesdomain. Its units are moved fromsecurity.*.xlftomessages.*.xlffor cs, de, en, fr, nl, ru and sk, keeping the wording.hKmDb7qunit inmessages.{cs,en,fr,ru,sk}.xlfwas only looked up when the translatedaction.preview_secure_sharelabel was translated again bymacro.buttonlink(). fix(translations): stop translating two admin messages twice聽#3843 stops that, so the unit is removed.With #3843 merged up, the rendered text on 6.2 is the same as before in all bundled locales.