Preserve linked file line endings#63
Conversation
|
Also, discovered a deprecated (removed in Qt6) class property (QDragMoveEvent.pos), and updated it to QDragMoveEvent.position |
e971de6 to
7520d8e
Compare
| if not event.mimeData().hasFormat(self.mime_type): | ||
| event.accept() | ||
| tab_index = self.tabAt(event.pos()) | ||
| tab_index = self.tabAt(event.position().toPoint()) |
There was a problem hiding this comment.
This change breaks Qt5, here is the error in PyQt5==5.15.2:
Traceback (most recent call last):
File "C:\blur\dev\preditor\preditor\gui\drag_tab_bar.py", line 315, in dragMoveEvent
tab_index = self.tabAt(event.position())
AttributeError: 'QDragMoveEvent' object has no attribute 'position'The newly updated Qt.py QtCompat methods for this, and please update the pip requirements accordingly(Qt.py>=2.0.5).
https://github.com/mottosso/Qt.py#qt-6-transition-guide (see the tooltip in the table hyperlinks that apparently don't work)
mottosso/Qt.py#466
There was a problem hiding this comment.
Hmm, I don't get that error when I drag a tab in PyQt5.
I think I may have an extra PyQt5 installation.
pip list | findstr /i qt
blur-qt-plugins 5.15.10.4
PyQt5 5.15.9
pyqt5-plugins 5.15.9.2.3
PyQt5-Qt5 5.15.2
PyQt5_sip 12.17.0
pyqt5-tools 5.15.9.3.3
qt-material 2.17
Qt.py 2.0.5
qt5-applications 5.15.2.2.3
qt5-tools 5.15.2.1.3
QtSiteConfigBlur 0.8.0
sphinxcontrib-qthelp 1.0.7
I wonder if PyQt5 isn't supposed to be installed? Just PyQt5-Qt5?
There was a problem hiding this comment.
Hmmm, seems correct in PrEditor
>>> Qt.QtCore.qVersion()
5.15.2
There was a problem hiding this comment.
You have to drag the tab to a different group tab to trigger it.
2 participants
Checklist
Types of Changes
Proposed Changes