You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Moves the disk_usage service from venv1 to venv2: removed from core/pyproject.toml's workspace/sources and added to the exclude list, added to core/python-venv2/pyproject.toml, bumped its runtime deps to the venv2 baseline (fastapi==0.125.0, fastapi-versioning==0.10.0, loguru==0.7.3, pydantic==2.12.5, uvicorn==0.38.0), migrated the two pydantic v1 idioms in main.py (update_forward_refs()→model_rebuild(), .dict()→.model_dump()), and updated core/start-blueos-core to launch it under $BLUEOS_PYTHON_BIN_SECONDARY. Lock files regenerated accordingly.
Version pins now match the existing venv2 services (customization/helper/kraken/versionchooser) exactly, both pydantic v1 call sites in main.py are converted, and no other v1-only patterns (.parse_obj, .parse_raw, Config:, @validator, .json()) remain in the service. nginx routing to port 9151 is untouched.
No further comments, nice job 👍
Generated by PR Review Bot. This is advisory, a human reviewer must still approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.