Skip to content

feat(ghost): add universal guidance packages - #319

Open
opdich wants to merge 10 commits into
mainfrom
experiment/universal-cascade
Open

opdich wants to merge 10 commits into
mainfrom
experiment/universal-cascade

Conversation

@opdich

@opdich opdich commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add universal guidance packages that can be paired with brand fingerprints. The manifest's core: list and the nodes' requires graph determine delivery. Universal nodes arrive first, with prerequisites before dependents.
  • Include authority text in cascade pulls and expose each node's declared requires in Markdown and JSON. The authority text describes direct and transitive overrides, including priority marked with !important.
  • Preserve output for legacy brand.md packages.

Verification

  • pnpm check passed. The full suite passed 349 tests, with one Goose discovery test skipped.
  • The branch is based on 141e6756 and merges cleanly with current main. All 288 legacy CLI comparisons against 141e6756 matched byte for byte.
  • Verified the rebuilt package in a downstream integration, including guidance pulls and generation prompts.

🤖 Generated with Claude Code

opdich and others added 6 commits November 18, 2026 11:44
Resolve automatic roots and selected node prerequisites across the two package owners, preserving legacy cover behavior.

Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Expose automatic guidance and version diagnostics, validate fallback policies and graph errors across the cascade, and measure explicit requests in stats.

Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Carry the original rule authority through embedded pulls and both CLI output formats.

Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Keep the package loader and output decisions in each command.

Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Group the dependency closure by package, preserving prerequisites and core-first delivery within each group.

Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>

@chailandau chailandau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Chai read and approved these comments.

Comment thread packages/ghost/src/embed/pull.ts Resolved
opdich and others added 3 commits November 19, 2026 14:44
Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
Co-authored-by: Big Ed <1e04291f32fc24a8e2f5e52e208aa27d61d5891ada99a679443b5488c4d723ad@buzz.block.builderlab.xyz>
.map((id) =>
guidanceNode(catalog.nodes.get(id) as GhostCatalogNode, !!cascade),
);
const shownNodeIds = new Set([...matchedIds, ...resolution.explicitNodeIds]);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [P2] Show which rule wins. Chai reviewed this follow-up. The --node case is fixed. When a check is the only reason a rule appears in the review, the output can still omit the rule it overrides. Can we include both rules, show which one wins, and add a test for that case?

Updated by Pushback 🤖

});
}

if (snapshot.cascade?.universalDir && inlineMaterials) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [P2] Make shared packages work from the work repo. Chai reviewed this follow-up. Paired pulls now give the correct asset path. The installed setup instructions still need the required --universal flag for paired packages, and standalone pulls still need to print an asset path the agent can open from its work repo. Can we test both paths from a separate repo?

Updated by Pushback 🤖

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants