COPLAN-35: Keep Mermaid comments clickable#148
Open
aushvin23 wants to merge 1 commit into
Open
Conversation
aushvin23
marked this pull request as ready for review
July 17, 2026 01:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Plan authors and reviewers need to open, reply to, and resolve feedback anchored to architecture diagrams. Asynchronous Mermaid rendering currently removes those anchors after initial page load, leaving visible comment counts with no clickable thread in active reviews.
What changes
Why this approach
This reuses the existing anchor matching and popover behavior on Mermaid's rendered HTML labels. A scoped Stimulus event coordinates diagram completion with comment highlighting without introducing a diagram-specific thread model or a second comment UI.
Risk / rollback
Risk is low and scoped to successfully rendered Mermaid content. Invalid diagrams continue to show their source and existing error state. Reverting this commit restores the previous behavior.
Test plan
rvm use ruby-3.4.7-portable do bundle exec rspec spec/system/comment_ux_spec.rb:180 spec/system/comment_ux_spec.rb:236rvm use ruby-3.4.7-portable do bundle exec rspec(1,132 examples, 0 failures)node --check engine/app/javascript/controllers/coplan/mermaid_controller.jsnode --check engine/app/javascript/controllers/coplan/text_selection_controller.jsReferences
Linked ticket
Generated with Codex