Repository navigation
Conversation
Uses config variables for customised links for any repo that embeds this shared content
freakboy3742
left a comment
There was a problem hiding this comment.
The extra content looks great; the only question I've got is about the location of the content. It's currently on the "how" page; but it seems to be more of a "what" question (which is born out by both the heading, and the shortlink added in beeware/beeware.github.io#839. Would it make sense to move this paragraph to the what/pr_review page?
Related to that - was the intention to update this content to include an explicit reference to the short links once they're available (which they now are)?
|
I've moved the updates to the what page, which is also the b/review-guide shortlink. Only one shortlink is valid in this context, so I've replaced that. We could add a shortlink for "review-passing" or similar, but the context-aware link can't shortened, but it should still work in the what page (presuming how is inset of what, it should work across repo includes) |
Uses config variables for customised links for any repo that embeds this shared content
beeware/beeware#618
PR Checklist: