[FEATURE] Fallback icon for non-image media files#51
Open
davidsteeb wants to merge 1 commit into
Open
Conversation
Media previews rendered the file via f:image only, which breaks or stays empty for non-image files (e.g. video/audio in the media field). Render a TYPO3 file type icon (video/audio/generic) as a fallback when the file is not an image. Resolves: BEXT-223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media previews rendered files via
f:imageonly. For non-image files (e.g. a video or audio file in themediafield of a textmedia element) this breaks or leaves the preview empty.Changes
Media/Image.html: branch on the file type — renderf:imagefor images (type 2) and a TYPO3<core:icon>fallback otherwise (mimetypes-media-video/mimetypes-media-audio/mimetypes-other-other)..b_image--iconstyling so the fallback aligns with image previews.Pure Fluid/CSS solution — no version-specific PHP (works on TYPO3 v10.4–v14). PHPStan v14 passes locally.
Resolves BEXT-223.