Skip to content

test: EKS add-on support#601

Open
ThirdEyeSqueegee wants to merge 3 commits intomainfrom
addon-test
Open

test: EKS add-on support#601
ThirdEyeSqueegee wants to merge 3 commits intomainfrom
addon-test

Conversation

@ThirdEyeSqueegee
Copy link
Copy Markdown
Member

@ThirdEyeSqueegee ThirdEyeSqueegee commented Apr 13, 2026

Description

Why is this change being made?

  1. Add support for testing the EKS add-on by passing --addon and --addon-version flags to run-tests.sh

What is changing?

  1. Add a new integ test install method for the provider governed by the --addon flag in run-tests.sh
    i. --addon-version can be used to specify an add-on version to test
  2. Update README.md with add-on testing instructions
  3. Add addon_config_values.yaml to pass config options to add-on for integ tests
  4. Add check to fail fast if POD_IDENTITY_ROLE_ARN is undefined when Pod Identity configs are selected for test runs
  5. Dynamically fetch cluster role for RBAC validation test case

Related Links

  • Issue #, if available:
    N/A

Testing

How was this tested?

  1. Ran integ tests locally: ./run-tests --addon x64 and ./run-tests.sh x64 --addon --addon-version v3.0.0-eksbuild.1
    i. All tests pass

When testing locally, provide testing artifact(s):

  1. N/A

Reviewee Checklist

Update the checklist after submitting the PR

  • I have reviewed, tested and understand all changes
    If not, why:
  • I have filled out the Description and Testing sections above
    If not, why:
  • Build and Unit tests are passing
    If not, why:
  • Unit test coverage check is passing
    If not, why:
  • Integration tests pass locally
    If not, why:
  • I have updated integration tests (if needed)
    If not, why:
  • I have ensured no sensitive information is leaking (i.e., no logging of sensitive fields, or otherwise)
    If not, why:
  • I have added explanatory comments for complex logic, new classes/methods and new tests
    If not, why:
  • I have updated README/documentation (if needed)
    If not, why:
  • I have clearly called out breaking changes (if any)
    If not, why:

Reviewer Checklist

All reviewers please ensure the following are true before reviewing:

  • Reviewee checklist has been accurately filled out
  • Code changes align with stated purpose in description
  • Test coverage adequately validates the changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ThirdEyeSqueegee ThirdEyeSqueegee requested a review from a team as a code owner April 13, 2026 00:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.84%. Comparing base (9126200) to head (e443af1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   60.84%   60.84%           
=======================================
  Files          11       11           
  Lines         710      710           
=======================================
  Hits          432      432           
  Misses        261      261           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThirdEyeSqueegee ThirdEyeSqueegee added the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Apr 13, 2026
@ThirdEyeSqueegee ThirdEyeSqueegee requested review from a team and simonmarty and removed request for a team April 13, 2026 00:32
Comment thread tests/run-tests.sh
Comment thread tests/integration.bats.template Outdated
log "Installing secrets-store-csi-driver via Helm"
KUBECONFIG=${{KUBECONFIG_VAR}} helm --namespace=$NAMESPACE install --wait --wait-for-jobs --timeout=30s csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver --set enableSecretRotation=true --set rotationPollInterval=15s --set syncSecret.enabled=true --set tokenRequests[0].audience=sts.amazonaws.com --set tokenRequests[1].audience=pods.eks.amazonaws.com
log "Installing secrets-store-csi-driver via Helm"
KUBECONFIG=${{KUBECONFIG_VAR}} helm --namespace=$NAMESPACE install --wait --wait-for-jobs --timeout=30s csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver --set enableSecretRotation=true --set rotationPollInterval=15s --set syncSecret.enabled=true --set tokenRequests[0].audience=sts.amazonaws.com --set tokenRequests[1].audience=pods.eks.amazonaws.com
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, for a followup, (you don't have to do it in this PR, and you don't have to be the one to do it):

We might as well install the provider here through the helm chart and install the driver as a Helm dependency instead of in two separate steps. We just have to pass the config options we're passing here to the underlying driver chart. That way the addon and the provider flows are more similar.

@github-actions github-actions Bot removed the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Apr 13, 2026
@ThirdEyeSqueegee ThirdEyeSqueegee added the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Apr 13, 2026
@github-actions github-actions Bot removed the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants