fix: replace efs-proxy bind panic with graceful error exit#355
Open
guessi wants to merge 1 commit into
Open
Conversation
efs-proxy panicked with an unhelpful backtrace when it failed to bind to 127.0.0.1:<port>. This manifested as a hard crash with no actionable error message in environments like Bottlerocket/EKS containers where the loopback bind can fail (e.g. permission denied, address in use). Change Controller::new to return Result<Self, io::Error> and have main() exit with code 1 and a clear error message instead of panicking. The mount helper already detects a non-zero efs-proxy exit and surfaces it to the user via mount.log. Fixes aws#323
guessi
force-pushed
the
fix/efs-proxy-bind-panic-issue-323
branch
from
f6e1db7 to
d2fc42d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
efs-proxy panics with an unhelpful Rust backtrace when it cannot bind to
127.0.0.1:<port>. This is reproducible in Bottlerocket/EKS containers and surfaces as:The mount then fails with a
DeadlineExceededor timeout error, giving the user no actionable information about the root cause.Fixes #323
Change
Controller::newnow returnsResult<Self, io::Error>instead of panicking.error!log is emitted with the address and the OS error (e.g.permission denied,address already in use).main()callsprocess::exit(1)on failure, producing a non-zero exit code that the mount helper already detects and surfaces inmount.log.Testing
cargo testsuite passes.cargo buildsucceeds with no warnings on the changed files.