fix: lazy import requests in dataset_providers to fix ModuleNotFoundE…#507
Open
saeekailas wants to merge 1 commit into
Open
fix: lazy import requests in dataset_providers to fix ModuleNotFoundE…#507saeekailas wants to merge 1 commit into
saeekailas wants to merge 1 commit into
Conversation
…rror on fresh install Signed-off-by: Saee Barve <saeekailas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
importing anything from bedrock_agentcore.evaluation on a fresh install
failed with ModuleNotFoundError: No module named 'requests' because
requests was imported at the top of dataset_providers.py but was not
declared as a runtime dependency in pyproject.toml.
Fix:
Moved
import requestsfrom the module-level into the body ofDatasetManagementServiceProvider.get_dataset(), so it is only imported
when actually needed. Users who never download datasets from a URL are
not affected and no longer require requests to be installed.
Files changed:
src/bedrock_agentcore/evaluation/runner/dataset_providers.py