feat: add ability to pass docker build params in template

[reedham-aws]

Which issue(s) does this change fix?

#8656

Why is this change necessary?

It had not been previously possible to pass in standard Docker arguments to the CLI build. While this isn't a big issue, it's a nice quality of life feature to add.

How does it address the issue?

Adds the ability to read extra parameters from the metadata of a SAM template, similar to how we already read build args that go into the Dockerfile. These parameters are then appended to the Docker/Finch CLI subprocess call.

What side effects does this change have?

Should have none because this is opt-in. Integration tests should confirm this.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

• Review the generative AI contribution guidelines
• Add input/output type hints to new functions/methods
• Write design document if needed (Do I need to write a design document?)
• Write/update unit tests
• Write/update integration tests
• Write/update functional tests if needed
• make pr passes
• make update-reproducible-reqs if dependencies were changed
• Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

This review has been superseded by a newer review.

[github-actions]

This review has been superseded by a newer review.

[github-actions]

Code Review Results

Reviewed: 09c3cd5..31cf82c
Files: 6
Comments: 2

[github-actions]

[INPUT_VALIDATION] The validation checks that DockerBuildExtraParams is a list, but does not verify that each element is a string. In CLIBuildClient.build_image, the list is passed directly to cmd.extend(extra_params) which feeds into subprocess.Popen. If a user provides non-string elements (e.g., integers, booleans, nested lists/dicts in their template metadata), this will raise a TypeError at runtime.

Consider adding element-type validation:

if docker_build_extra_params is not None and not isinstance(docker_build_extra_params, list):
   raise DockerBuildFailed("DockerBuildExtraParams needs to be a list!")

if docker_build_extra_params is not None and not all(isinstance(p, str) for p in docker_build_extra_params):
   raise DockerBuildFailed("All items in DockerBuildExtraParams must be strings!")