Skip to content

fix(core): detect bundled SDK via version stamp - #717

Merged
yaythomas merged 2 commits into
mainfrom
feat/bundled-stamp-detection
Oct 24, 2026
Merged

yaythomas merged 2 commits into
mainfrom
feat/bundled-stamp-detection

Conversation

@nvasiu

@nvasiu nvasiu commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:

N/A

Description of changes:

The managed runtime now stamps a +bundled local version label onto the installed durable SDK. This update reads the stamp to determine if the SDK is installed in the managed runtime (replacing the old method of checking the installation folder, which was unreliable).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nvasiu
nvasiu temporarily deployed to ai-pr-review-runtime September 10, 2026 18:04 — with GitHub Actions Inactive
@nvasiu
nvasiu temporarily deployed to ai-pr-review-runtime September 10, 2026 18:12 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@nvasiu
nvasiu force-pushed the feat/bundled-stamp-detection branch from 7469710 to f30b5b7 Compare September 15, 2026 22:39
@nvasiu
nvasiu temporarily deployed to ai-pr-review-runtime September 15, 2026 22:45 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@nvasiu
nvasiu force-pushed the feat/bundled-stamp-detection branch from f30b5b7 to bc34fea Compare September 15, 2026 23:12
@nvasiu
nvasiu temporarily deployed to ai-pr-review-runtime September 15, 2026 23:13 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

Comment thread packages/aws-durable-execution-sdk-python/tests/lambda_service_test.py Outdated
@nvasiu
nvasiu force-pushed the feat/bundled-stamp-detection branch from bc34fea to 73e21a2 Compare September 16, 2026 17:14
@nvasiu
nvasiu temporarily deployed to ai-pr-review-runtime September 16, 2026 17:14 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@nvasiu
nvasiu force-pushed the feat/bundled-stamp-detection branch from 73e21a2 to 83ce7a5 Compare September 16, 2026 23:43
@nvasiu
nvasiu temporarily deployed to ai-pr-review-runtime September 16, 2026 23:43 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 16, 2026 19:09 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 16, 2026 19:53 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@nvasiu
nvasiu force-pushed the feat/bundled-stamp-detection branch from 509340c to c7a4675 Compare October 23, 2026 23:54
@nvasiu
nvasiu temporarily deployed to ai-pr-review-runtime October 23, 2026 23:54 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 24, 2026 00:19 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Both prior findings are resolved. Tests were not executed under the review restrictions; managed-runtime version stamping remains a residual integration risk.

Reviewed commit ce74ed8a204a403b7da8e474f571e5b5d020c112. Workflow run

@yaythomas yaythomas left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Squash on merge please. The commit title is already conventional.

@yaythomas
yaythomas merged commit 7aec444 into main Oct 24, 2026
69 checks passed
@yaythomas
yaythomas deleted the feat/bundled-stamp-detection branch October 24, 2026 06:48

This branch was previously deployed

1 inactive deployment
ai-pr-review-runtime — ce74ed8a Deployed Oct 24, 2026 by zhongkechen via ai-pr-review / Codex review / Generate Codex review #2249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants