Skip to content

Commit 06fc7d4

Browse files
committed
test: fix unit test failure due to missing file
1 parent fb01d10 commit 06fc7d4

21 files changed

Lines changed: 82 additions & 47 deletions

common/lib/authentication/aws_secrets_manager_plugin.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ export class AwsSecretsManagerPlugin extends AbstractConnectionPlugin implements
141141
}
142142
}
143143
logger.debug(Messages.get("AwsSecretsManagerConnectionPlugin.unhandledError", error.name, error.message));
144+
throw error;
144145
}
145146
}
146147

common/lib/database_dialect/topology_aware_database_dialect.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,7 @@ export interface TopologyAwareDatabaseDialect {
3434
export interface GlobalAuroraTopologyDialect extends TopologyAwareDatabaseDialect {
3535
getRegionByInstanceId(targetClient: ClientWrapper, instanceId: string): Promise<string | null>;
3636
}
37+
38+
export function isDialectTopologyAware(dialect: any): dialect is TopologyAwareDatabaseDialect {
39+
return dialect;
40+
}

common/lib/host_list_provider/aurora_topology_utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { TopologyQueryResult, TopologyUtils } from "./topology_utils";
1818
import { ClientWrapper } from "../client_wrapper";
1919
import { DatabaseDialect } from "../database_dialect/database_dialect";
2020
import { HostInfo } from "../host_info";
21-
import { isDialectTopologyAware } from "../utils/utils";
21+
import { isDialectTopologyAware } from "../database_dialect/topology_aware_database_dialect";
2222
import { Messages } from "../utils/messages";
2323

2424
/**

common/lib/host_list_provider/global_topology_utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { TopologyQueryResult, TopologyUtils } from "./topology_utils";
1818
import { ClientWrapper } from "../client_wrapper";
1919
import { DatabaseDialect } from "../database_dialect/database_dialect";
2020
import { HostInfo } from "../host_info";
21-
import { isDialectTopologyAware } from "../utils/utils";
21+
import { isDialectTopologyAware } from "../database_dialect/topology_aware_database_dialect";
2222
import { Messages } from "../utils/messages";
2323
import { AwsWrapperError } from "../utils/errors";
2424

common/lib/host_list_provider/monitoring/cluster_topology_monitor.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ export class ClusterTopologyMonitorImpl extends AbstractMonitor implements Clust
6262
protected static readonly DEFAULT_CONNECTION_TIMEOUT_MS: number = 5000;
6363
protected static readonly DEFAULT_QUERY_TIMEOUT_MS: number = 5000;
6464

65-
static readonly MONITORING_PROPERTY_PREFIX: string = "topology_monitoring_";
66-
6765
private readonly clusterId: string;
6866
protected readonly initialHostInfo: HostInfo;
6967
private readonly servicesContainer: FullServicesContainer;
@@ -129,8 +127,8 @@ export class ClusterTopologyMonitorImpl extends AbstractMonitor implements Clust
129127

130128
this._monitoringProperties = new Map<string, any>(props);
131129
for (const [key, val] of props) {
132-
if (key.startsWith(ClusterTopologyMonitorImpl.MONITORING_PROPERTY_PREFIX)) {
133-
this._monitoringProperties.set(key.substring(ClusterTopologyMonitorImpl.MONITORING_PROPERTY_PREFIX.length), val);
130+
if (key.startsWith(WrapperProperties.TOPOLOGY_MONITORING_PROPERTY_PREFIX)) {
131+
this._monitoringProperties.set(key.substring(WrapperProperties.TOPOLOGY_MONITORING_PROPERTY_PREFIX.length), val);
134132
this._monitoringProperties.delete(key);
135133
}
136134
}

common/lib/host_list_provider/rds_host_list_provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { AwsTimeoutError, AwsWrapperError } from "../utils/errors";
2525
import { Messages } from "../utils/messages";
2626
import { WrapperProperties } from "../wrapper_property";
2727
import { logger } from "../../logutils";
28-
import { isDialectTopologyAware } from "../utils/utils";
28+
import { isDialectTopologyAware } from "../database_dialect/topology_aware_database_dialect";
2929
import { DatabaseDialect } from "../database_dialect/database_dialect";
3030
import { ClientWrapper } from "../client_wrapper";
3131
import { CoreServicesContainer } from "../utils/core_services_container";

common/lib/internal_pooled_connection_provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { lookup, LookupAddress } from "dns";
2727
import { promisify } from "util";
2828
import { HostInfoBuilder } from "./host_info_builder";
2929
import { RdsUrlType } from "./utils/rds_url_type";
30-
import { AwsWrapperError } from "./index";
30+
import { AwsWrapperError } from "./utils/errors";
3131
import { Messages } from "./utils/messages";
3232
import { HostSelector } from "./host_selector";
3333
import { RandomHostSelector } from "./random_host_selector";

common/lib/plugin_service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import { DynamicHostListProvider, HostListProvider } from "./host_list_provider/
2222
import { ConnectionUrlParser } from "./utils/connection_url_parser";
2323
import { DatabaseDialect, DatabaseType } from "./database_dialect/database_dialect";
2424
import { HostInfoBuilder } from "./host_info_builder";
25-
import { AwsTimeoutError, AwsWrapperError, UnsupportedMethodError } from "./";
25+
import { AwsTimeoutError, AwsWrapperError, UnsupportedMethodError } from "./utils/errors";
2626
import { HostAvailability } from "./host_availability/host_availability";
2727
import { HostAvailabilityCacheItem } from "./host_availability/host_availability_cache_item";
2828
import { StatusCacheItem } from "./utils/status_cache_item";

common/lib/plugins/bluegreen/blue_green_status_provider.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ import { FullServicesContainer } from "../../utils/full_services_container";
4545
import { StorageService } from "../../utils/storage/storage_service";
4646

4747
export class BlueGreenStatusProvider {
48-
static readonly MONITORING_PROPERTY_PREFIX = "blue_green_monitoring_";
4948
private static readonly DEFAULT_CONNECT_TIMEOUT_MS = 10_000; // 10 seconds
5049
private static readonly DEFAULT_QUERY_TIMEOUT_MS = 10_000; // 10 seconds
5150

@@ -134,7 +133,7 @@ export class BlueGreenStatusProvider {
134133
const monitoringConnProperties: Map<string, any> = new Map(this.properties);
135134

136135
for (const key of monitoringConnProperties.keys()) {
137-
if (!key.startsWith(BlueGreenStatusProvider.MONITORING_PROPERTY_PREFIX)) {
136+
if (!key.startsWith(WrapperProperties.BG_MONITORING_PROPERTY_PREFIX)) {
138137
continue;
139138
}
140139

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
/*
2+
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License").
5+
You may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
export class StatusCacheItem<T> {
18+
readonly status: T;
19+
20+
constructor(status: T) {
21+
this.status = status;
22+
}
23+
}

0 commit comments

Comments
 (0)