chore: address comments

Author: karenc-bq

common/lib/host_list_provider/monitoring/cluster_topology_monitor.ts

@@ -433,18 +433,19 @@ export class ClusterTopologyMonitorImpl extends AbstractMonitor implements Clust
               // Update host monitors with the new instances in the topology.
               const hosts: HostInfo[] | null = this.hostMonitorsLatestTopology;
               if (hosts && !this.hostMonitorsStop) {
-                hosts.forEach((hostInfo) => {
+                for (const hostInfo of hosts) {
                   if (!this.submittedHosts.get(hostInfo.host)) {
                     const minimalServiceContainer = ServiceUtils.instance.createMinimalServiceContainerFrom(
                       this.servicesContainer,
                       this._monitoringProperties
                     );
-                    minimalServiceContainer.pluginManager.init();
+                    await minimalServiceContainer.pluginManager.init();
+                    // Intentionally not calling await on hostMonitor.run().
                     const hostMonitor = new HostMonitor(minimalServiceContainer, this, hostInfo, this.writerHostInfo);
                     const promise = hostMonitor.run();
                     this.submittedHosts.set(hostInfo.host, promise);
                   }
-                });
+                }
               }
             }
           }

common/lib/partial_plugin_service.ts

@@ -17,7 +17,7 @@
 import { PluginService } from "./plugin_service";
 import { HostInfo } from "./host_info";
 import { AwsClient } from "./aws_client";
-import { HostListProvider } from "./host_list_provider/host_list_provider";
+import { DynamicHostListProvider, HostListProvider } from "./host_list_provider/host_list_provider";
 import { ConnectionUrlParser } from "./utils/connection_url_parser";
 import { DatabaseDialect } from "./database_dialect/database_dialect";
 import { HostInfoBuilder } from "./host_info_builder";
@@ -296,7 +296,7 @@ export class PartialPluginService implements PluginService, HostListProviderServ
     }
 
     try {
-      const updatedHostList = await (hostListProvider as any).forceMonitoringRefresh(shouldVerifyWriter, timeoutMs);
+      const updatedHostList = await (hostListProvider as DynamicHostListProvider).forceMonitoringRefresh(shouldVerifyWriter, timeoutMs);
       if (updatedHostList) {
         this.updateHostAvailability(updatedHostList);
         this.setHostList(this.hosts, updatedHostList);

common/lib/plugin_manager.ts

@@ -442,7 +442,7 @@ export class PluginManager {
 
     for (const p of this._plugins) {
       if (p instanceof iface) {
-        return p as any;
+        return p as T;
       }
     }
     return null;

common/lib/plugins/failover2/failover2_plugin.ts

@@ -469,8 +469,8 @@ export class Failover2Plugin extends AbstractConnectionPlugin {
     }
 
     this.failoverMode = failoverModeFromValue(WrapperProperties.FAILOVER_MODE.get(this.properties));
-    const initialHostInfo: HostInfo = this.hostListProviderService.getInitialConnectionHostInfo();
-    this.rdsUrlType = this.rdsHelper.identifyRdsType(initialHostInfo.host);
+    const initialHostInfo: HostInfo | undefined | null = this.hostListProviderService?.getInitialConnectionHostInfo();
+    this.rdsUrlType = this.rdsHelper.identifyRdsType(initialHostInfo?.host);
 
     if (this.failoverMode === FailoverMode.UNKNOWN) {
       this.failoverMode = this.rdsUrlType === RdsUrlType.RDS_READER_CLUSTER ? FailoverMode.READER_OR_WRITER : FailoverMode.STRICT_WRITER;