Repository navigation
chore(ci): bump v1 canary frequency - #2696
Merged
Merged
Conversation
Contributor
Package TarballHow to installgh release download pr-2696-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Single-line schedule change (15 * * * * → 15,45 * * * *). Cron syntax is valid, the workflow still keeps concurrency: group: canary with cancel-in-progress: false, and with ~15 min runtimes there's still headroom against the 30-minute cadence. Nothing here blocks merge.
Two non-blocking notes for the author's awareness (no code changes required):
.github/workflows/canary.yml:4-5— the change drops the comment that pointed at the coupling between this cron and theAgentCoreCLI/Canaryalarm's missing-data window. That window was presumably widened when the cadence moved to hourly; moving back to 30 min is safe for missing-data (more samples, not fewer), but the alarm is now less sensitive than it could be. Worth either tightening the alarm window as a follow-up or keeping a one-line comment so the cadence/alarm coupling stays discoverable.- Because
e2e-test.ymlsets notimeout-minutes(default 360), a hung run plus the tighter cadence makes queued-run cancellation more likely; a run cancelled while pending never reaches theheartbeatjob, so it emits no sample and relies on the alarm's missing-data behavior. That's existing behavior, not introduced here, but the margin is halved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2696 +/- ##
=========================================
Coverage 96.62% 96.62%
=========================================
Files 706 706
Lines 58444 58447 +3
=========================================
+ Hits 56469 56473 +4
+ Misses 1975 1974 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase canary run frequency from 60 minutes to 30 minutes. Our total execution time dropped from ~45 minutes to ~15 minutes after runner updates; which warrants a quicker schedule. Set to run at :15 and :45 of each hour
Type of Change
Testing
How have you tested the change?
bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.