Skip to content

chore(ci): bump v1 canary frequency - #2696

Merged
nborges-aws merged 1 commit into
refactorfrom
update-canary-period
Oct 23, 2026
Merged

nborges-aws merged 1 commit into
refactorfrom
update-canary-period

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

Increase canary run frequency from 60 minutes to 30 minutes. Our total execution time dropped from ~45 minutes to ~15 minutes after runner updates; which warrants a quicker schedule. Set to run at :15 and :45 of each hour

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@nborges-aws
nborges-aws requested a review from a team October 23, 2026 16:59
@github-actions github-actions Bot added the size/xs PR size: XS label Oct 23, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-1.0.0.tgz

How to install

gh release download pr-2696-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.0.tgz

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 23, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Single-line schedule change (15 * * * * → 15,45 * * * *). Cron syntax is valid, the workflow still keeps concurrency: group: canary with cancel-in-progress: false, and with ~15 min runtimes there's still headroom against the 30-minute cadence. Nothing here blocks merge.

Two non-blocking notes for the author's awareness (no code changes required):

  • .github/workflows/canary.yml:4-5 — the change drops the comment that pointed at the coupling between this cron and the AgentCoreCLI/Canary alarm's missing-data window. That window was presumably widened when the cadence moved to hourly; moving back to 30 min is safe for missing-data (more samples, not fewer), but the alarm is now less sensitive than it could be. Worth either tightening the alarm window as a follow-up or keeping a one-line comment so the cadence/alarm coupling stays discoverable.
  • Because e2e-test.yml sets no timeout-minutes (default 360), a hung run plus the tighter cadence makes queued-run cancellation more likely; a run cancelled while pending never reaches the heartbeat job, so it emits no sample and relies on the alarm's missing-data behavior. That's existing behavior, not introduced here, but the margin is halved.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 23, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (4b5d3ca) to head (0693043).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2696   +/-   ##
=========================================
  Coverage     96.62%   96.62%           
=========================================
  Files           706      706           
  Lines         58444    58447    +3     
=========================================
+ Hits          56469    56473    +4     
+ Misses         1975     1974    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nborges-aws
nborges-aws merged commit d4f5a61 into refactor Oct 23, 2026
27 of 28 checks passed
@nborges-aws
nborges-aws deleted the update-canary-period branch October 23, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants