feat(project): implement resolve() + container template on FsTreeNode - #1946
Merged
Conversation
Locate an existing project by walking up to the agentcore/agentcore.json
marker, parse it through ProjectSpecSchema, and return { name, rootPath,
runtimes }. A malformed config surfaces as InputValidationError (user-
correctable) rather than a raw DeserializationError.
- extend Project with rootPath + runtimes (what withProject and the dev
server actually consume)
- inject ReadWriteJson into FsProjectManager (tests read fixtures, not disk)
- create() returns the same shape resolve() would
…ed no-project error - add hello-world-python-container template (Dockerfile + assets) and its TEMPLATES entry (build: Container, dockerfile). z.enum(PROJECT_TEMPLATES) exposes it as a --template choice automatically. - fix fsTree renderName regex to rename dockerignore.template -> .dockerignore (previously only git/npm), so the container template's ignore file lands right. - scaffold a root .gitignore and agentcore/.env.local from shared/ templates. - withProject: throw InputValidationError when no project encloses the cwd, replacing the placeholder raw Error (unblocked by resolve()).
github-actions
Bot
added
the
agentcore-harness-reviewing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #1946 +/- ##
=========================================
Coverage 95.74% 95.75%
=========================================
Files 291 291
Lines 16234 16273 +39
=========================================
+ Hits 15544 15582 +38
- Misses 690 691 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
agentcore-harness-reviewing
aidandaly24
approved these changes
Aug 7, 2026
aidandaly24
left a comment
aidandaly24
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me! Very clean PR.
nborges-aws
approved these changes
Aug 10, 2026
jariy17
reviewed
Aug 10, 2026
jariy17
left a comment
jariy17
left a comment
Contributor
There was a problem hiding this comment.
If you can do this as a follow up PR, that would be great
|
|
||
|
|
||
| @app.entrypoint | ||
| async def invoke(payload, context): |
Contributor
There was a problem hiding this comment.
Can you apply stripping_tool_use function to the request? We had a sev2 about this issue. https://github.com/aws/agentcore-cli/pull/1898/changes
| requires-python = ">=3.10" | ||
| dependencies = [ | ||
| "aws-opentelemetry-distro", | ||
| "bedrock-agentcore >= 1.9.1", |
Contributor
There was a problem hiding this comment.
Can we set this version a little higher?
| dependencies = [ | ||
| "aws-opentelemetry-distro", | ||
| "bedrock-agentcore >= 1.9.1", | ||
| "botocore[crt] >= 1.35.0", |
Contributor
There was a problem hiding this comment.
Can we set this version a little higher?
| "aws-opentelemetry-distro", | ||
| "bedrock-agentcore >= 1.9.1", | ||
| "botocore[crt] >= 1.35.0", | ||
| "strands-agents >= 1.15.0", |
Contributor
There was a problem hiding this comment.
Can we set this version a little higher?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectManager.resolve()by locating and validating the nearestagentcore/agentcore.jsonhello-world-python-containertemplate and scaffold shared.gitignoreandagentcore/.env.localfilesSupersedes #1880 after the project schema and
FsTreeNodescaffolding landed separately.Testing
bun test(972 pass)