network: read the documented host key for the mdns config - #2366
Merged
Conversation
bettio
approved these changes
Jul 19, 2026
mdns_config() documents {host, ...} but maybe_start_mdns read the
`hostname` key, so a spec-conforming config handed mdns:init an
undefined hostname and it crashed on iolist_to_binary/1. Accept both,
preferring the documented key.
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w29/mdns-host-key
branch
from
July 20, 2026 19:45
c7a0e8a to
d61eb6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mdns_config() documents {host, ...} but maybe_start_mdns read the
hostnamekey, so a spec-conforming config handed mdns:init an undefined hostname and it crashed on iolist_to_binary/1. Accept both, preferring the documented key.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later