fix: prolong and track shared request queue locks to prevent duplicate processing - #1062
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
- Coverage 91.89% 91.87% -0.02%
==========================================
Files 51 51
Lines 3232 3274 +42
==========================================
+ Hits 2970 3008 +38
- Misses 262 266 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Btw. this is a different case than #887 |
vdusek
marked this pull request as ready for review
July 21, 2026 18:47
Pijukatel
reviewed
Jul 22, 2026
Pijukatel
approved these changes
Aug 19, 2026
vdusek
added a commit
that referenced
this pull request
Aug 19, 2026
Combines the lock tracking from #1062 with the `is_finished` verification here: - `is_finished` keeps the cheap early-out (empty head, no platform locks, no locally in-progress request) and only then confirms the empty-head verdict against per-request reads. - `reclaim_request` reuses the `request_id` that #1062 now binds before the try block for `_requests_in_progress`. - Tests: kept both sets; #1062's always-unhandled `_client_request` helper was dropped in favour of the existing one that takes `handled_at`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared request-queue client (
access='shared') locked a batch of up to 25 requests for 180 s inlist_and_lock_head, but never tracked, prolonged, or released those locks. As a batch drained slowly, locks expired mid-flight and requests got processed twice - by another consumer that re-locked an expired request, or by a second worker in this process after the request was re-listed. That defeats the class's documented "request locking to prevent duplicate processing" guarantee (double charges in PPE, duplicate dataset items).Changes:
lock_expires_atper cached head entry (the API returned it, we discarded it)._requests_in_progress: skip them when re-listing the head and when fetching, and keepis_finishedfalse while any is outstanding.fetch_next_request, skip candidates whose lock already lapsed, and prolong the lock only when its remaining window is below half the lock time (_MIN_LOCK_TIME_AT_HANDOFF, 90 s). A request handed out from a fresh batch lock needs no prolong, so the common path adds no API write and shared mode stays at 3 writes per request.Out of scope: handlers outliving the lock window would need a background refresh loop, and deleting leftover head locks on shutdown has no
RequestQueueClienthook to attach to (they lapse within the lock TTL anyway).✍️ Drafted by Claude Code