Skip to content

docs: fix input guide example to bound the wait with wait_duration#955

Merged
vdusek merged 1 commit into
masterfrom
docs/fix-input-guide-wait-duration
Jul 16, 2026
Merged

docs: fix input guide example to bound the wait with wait_duration#955
vdusek merged 1 commit into
masterfrom
docs/fix-input-guide-wait-duration

Conversation

@vdusek

@vdusek vdusek commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

The "Pass input to an Actor" guide example claimed that timeout=timedelta(seconds=60) makes call() wait up to 60 seconds for the run to finish. It doesn't. On call(), timeout is the per-request HTTP timeout forwarded to start(), while the wait cap is wait_duration (default None, i.e. wait indefinitely). A user copying the example would block indefinitely on a long or never-finishing run. The sync and async examples now use wait_duration=timedelta(seconds=60) and the comment is reworded accordingly.

The stale copies under website/versioned_docs/ are left untouched on purpose. The versioning workflow deletes and re-snapshots version-3.0 from docs/ on every 3.x release, so the fix propagates there automatically.

🤖 Generated with Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jul 16, 2026
@vdusek vdusek self-assigned this Jul 16, 2026
@github-actions github-actions Bot added this to the 145th sprint - Tooling team milestone Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.63%. Comparing base (a8a393b) to head (cea8b05).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   94.61%   94.63%   +0.01%     
==========================================
  Files          58       58              
  Lines        5239     5239              
==========================================
+ Hits         4957     4958       +1     
+ Misses        282      281       -1     
Flag Coverage Δ
integration 92.82% <ø> (+0.15%) ⬆️
unit 83.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from Pijukatel July 16, 2026 13:28
@vdusek vdusek marked this pull request as ready for review July 16, 2026 13:28
@vdusek vdusek merged commit 179cb53 into master Jul 16, 2026
56 of 57 checks passed
@vdusek vdusek deleted the docs/fix-input-guide-wait-duration branch July 16, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants