Skip to content

fix: Propagate last_run status/origin filters to chained storage clients#954

Merged
vdusek merged 2 commits into
masterfrom
fix/propagate-last-run-params
Jul 17, 2026
Merged

fix: Propagate last_run status/origin filters to chained storage clients#954
vdusek merged 2 commits into
masterfrom
fix/propagate-last-run-params

Conversation

@vdusek

@vdusek vdusek commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

The status and origin filters passed to ActorClient.last_run(...) and TaskClient.last_run(...) were silently dropped by the chained storage clients. For example, actor.last_run(status='SUCCEEDED').dataset().list_items() queried the most recent run's dataset regardless of status. This is a regression vs 1.x, where _sub_resource_init_options forwarded the parent's params to every child client; the typed-client refactor (#604) lost that.

The fix passes the run client's default params to its four child-client factories (dataset(), key_value_store(), request_queue(), log()) in both RunClient and RunClientAsync, so the filters ride along on the runs/last storage endpoints again, matching 1.x and the JS client.

Adds a parametrized regression test covering all four chained clients, sync and async. All 8 cases fail before the fix and pass after.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jul 16, 2026
@vdusek vdusek self-assigned this Jul 16, 2026
@github-actions github-actions Bot added this to the 145th sprint - Tooling team milestone Jul 16, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.61%. Comparing base (a8a393b) to head (6344a57).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          58       58           
  Lines        5239     5239           
=======================================
  Hits         4957     4957           
  Misses        282      282           
Flag Coverage Δ
integration 92.67% <ø> (ø)
unit 83.85% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review July 16, 2026 13:32
@vdusek
vdusek requested a review from Pijukatel July 16, 2026 13:32
@vdusek
vdusek merged commit fe24058 into master Jul 17, 2026
30 checks passed
@vdusek
vdusek deleted the fix/propagate-last-run-params branch July 17, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants