Skip to content

test: Deflake test_schedule_list and test_task_list by polling eventually consistent listings#951

Merged
vdusek merged 2 commits into
masterfrom
test/deflake-schedule-list
Jul 16, 2026
Merged

test: Deflake test_schedule_list and test_task_list by polling eventually consistent listings#951
vdusek merged 2 commits into
masterfrom
test/deflake-schedule-list

Conversation

@vdusek

@vdusek vdusek commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

test_schedule_list and test_task_list failed in CI (schedule run, task run) because they assert read-your-write on listing endpoints: they list resources immediately after creating them, and under load the listing can serve a view that hasn't yet caught up with the creates, so the fresh IDs are sometimes missing. The creates themselves succeeded in both cases, so these are eventual-consistency flakes, not client bugs.

The fix wraps each list read in the existing poll_until_condition helper (30 s ceiling), waiting until the created IDs appear in the listing. The original assertions still run on the final page, so a real regression still fails. Follows the same deflaking pattern as #824, #831, #844, and #868.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jul 16, 2026
@vdusek vdusek self-assigned this Jul 16, 2026
@github-actions github-actions Bot added this to the 145th sprint - Tooling team milestone Jul 16, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.61%. Comparing base (a8a393b) to head (2ba22cf).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #951   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          58       58           
  Lines        5239     5239           
=======================================
  Hits         4957     4957           
  Misses        282      282           
Flag Coverage Δ
integration 92.67% <ø> (ø)
unit 83.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from Pijukatel July 16, 2026 13:23
@vdusek vdusek marked this pull request as ready for review July 16, 2026 13:23
@vdusek vdusek changed the title test: Deflake test_schedule_list by polling the eventually consistent listing test: Deflake test_schedule_list and test_task_list by polling eventually consistent listings Jul 16, 2026
@vdusek vdusek merged commit 4e7a566 into master Jul 16, 2026
30 checks passed
@vdusek vdusek deleted the test/deflake-schedule-list branch July 16, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants