feat: add httpx http client [test] - #1004
Draft
vdusek wants to merge 4 commits into
Draft
Conversation
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 94.86% 94.97% +0.10%
==========================================
Files 58 59 +1
Lines 5357 5472 +115
==========================================
+ Hits 5082 5197 +115
Misses 275 275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
force-pushed
the
add-httpx-client
branch
from
August 11, 2026 09:41
9e820de to
c4e20bc
Compare
`ProxyError` was classified as permanently non-retryable, so a proxy answering CONNECT with a transient status (502, 503, 429) failed on the first attempt instead of being retried, as it was before. Other changes from the same review pass: - Rename `_send_request` to `send_request` and `_is_retryable_transport_error` to `is_retryable_transport_error`, so the whole documented transport contract is public. - Drop the no-op hook overrides from the custom-client docs examples and the test doubles, and drop the pass-through `LogClient._is_timeout_error`. - Derive the expected `Accept-Encoding` from HTTPX instead of hard-coding whichever codecs are installed. - Build `__all__` as one literal per branch, so RUF022 keeps checking it. - Assert the HTTPX no-timeout mapping through the real `build_request` rather than through a mock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just testing smt