fix(doctrine): ignore associative values in exact filter#8411
Closed
ousamabenyounes wants to merge 4 commits into
Closed
fix(doctrine): ignore associative values in exact filter#8411ousamabenyounes wants to merge 4 commits into
ousamabenyounes wants to merge 4 commits into
Conversation
Member
|
thanks, superseeded by #8415 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExactFiltertreated any array value as anIN (...)filter. When another filter sharing the same query key receives an associative value, such as DateFilter'screatedAt[strictly_before]=..., ExactFilter consumed that associative array first and added an incorrectINclause.This makes ExactFilter ignore associative arrays and keep handling scalar values and list arrays.
Local review
Reviewed before opening this PR. No findings: the guard is before property validation/DQL generation, so associative values meant for another filter are skipped; the existing functional ExactFilter test suite still passes for current scalar/list behavior.
Test verification (RED → GREEN)
RED, after adding the regression test on upstream
main:GREEN, with the fix:
Fix-reverted regression check:
Additional checks:
All commands were run inside ephemeral Docker containers with
docker run --rm -u "$(id -u):$(id -g)" -v "$PWD":/app -w /app composer:2 ....