Conversation
spmallette
reviewed
Jun 1, 2026
spmallette
reviewed
Jun 1, 2026
spmallette
reviewed
Jun 1, 2026
GumpacG
reviewed
Jun 1, 2026
GumpacG
reviewed
Jun 1, 2026
GumpacG
reviewed
Jun 1, 2026
Cole-Greer
reviewed
Jun 5, 2026
Contributor
|
I agree with above comments from Stephen and Guian, but overall LGTM. VOTE +1 (pending comment resolutions) |
Contributor
|
One extra thing to note, this PR deletes a lot of the old commented out/skipped transaction tests in favour of a fresh set of tests. I'm fine with that change but I was comparing the old and new tests and found a few minor gaps: First of all there are still some old skipped transaction tests in python which have not been cleaned up here: Also the old Python and Go transaction tests seemed to have been a bit richer than the other GLVs, and contain a few cases which are not replicated in the new tests:
|
xiazcy
reviewed
Jun 5, 2026
Contributor
|
VOTE +1 pending comment resolution |
Split executeAndStream() into sendRequest() (synchronous HTTP call) and streamResponse() (async body streaming). submit() now blocks until the server acknowledges the request (response headers received), then streams the body in the background. Non-GraphBinary HTTP errors (400/500 with text/JSON bodies) are now returned directly from submit() instead of being embedded in the ResultSet. Tests updated accordingly. Assisted-by: Kiro:claude-opus-4-6
Implement Transaction classes in gremlin-python, gremlin-go, gremlin-javascript, and gremlin-dotnet that mirror the Java HttpRemoteTransaction. Transaction wraps a Client and provides begin/commit/rollback/close lifecycle plus a submit() method for plain gremlin-lang strings. Key design decisions: - Default close behavior changed from commit to rollback (all GLVs) - Transactions are single-use (terminal state after commit/rollback) - gtx.tx() returns the same Transaction (enables gtx.tx().commit()) Assisted-by: Kiro:claude-opus-4-6
Contributor
Author
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Transaction classes in gremlin-python, gremlin-go, gremlin-javascript, and gremlin-dotnet that mirror the Java HttpRemoteTransaction. Transaction wraps a Client and provides begin/commit/rollback/close lifecycle plus a submit() method for plain gremlin-lang strings.
gremlin-driver's default transaction close behavior is now rollback to match all GLVs.
Also changes how requests are submitted in gremlin-go. In particular it now waits for response headers before returning. This allows users to check if the response returns an err (pretty much any non-200 OK response), before having to check the ResultSet itself.