[common] Add shared-shredding write helpers for MAP columns#8332
Merged
Conversation
Contributor
|
Looks no problem, wait CI. |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a sub-PR for MAP shared-shredding write support. The full shared-shredding write path will be wired in later PRs.
MapSharedShreddingContextto maintain cross-file shared-shredding state and compute the next physical column widthK.MapSharedShreddingFieldDictto assign stable field ids for MAP keys within a shared-shredding field.MapSharedShreddingColumnAllocatorto allocate MAP entries into physical shared columns for each row.MapSharedShreddingRowConverterto lazily wrap logicalInternalRowrecords and convert shared-shredding MAP fields into their physical representation only when those fields are accessed.Related design:
https://cwiki.apache.org/confluence/display/PAIMON/PIP-43%3A+Columnar+Storage+Optimization+for+MAP+Type+in+Paimon
Tests
mvn -pl paimon-common -am -Pfast-build -DfailIfNoTests=false \ -Dtest=MapSharedShreddingColumnAllocatorTest,MapSharedShreddingContextTest,MapSharedShreddingFieldDictTest,MapSharedShreddingRowConverterTest test