[core] Sort data evolution manifests by RowID#8329
Merged
JingsongLi merged 3 commits intoJun 24, 2026
Merged
Conversation
JingsongLi
commented
Jun 23, 2026
leaves12138
approved these changes
Jun 23, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the RowID-aware manifest sort path. I checked the fallback behavior when RowID stats are incomplete, schema validation for data-evolution/non-partition tables, and the partition-first + RowID range ordering for data evolution manifests. No blocking issues found.
Validation:
git diff --checkmvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=ManifestFileMetaTest#testDataEvolutionManifestSortByPartitionAndRowId,NoPartitionManifestFileMetaTest#testDataEvolutionManifestSortByRowId,SchemaValidationTest#testManifestSortValidation test
Note: in this local temp workspace, the first test run hit the known codegen-loader ServiceLoader resource issue; after unpacking the codegen test resource, the targeted tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support manifest sort rewrite for data evolution tables by using RowID-aware sort keys. Partitioned data evolution tables sort entries by partition first, then RowID range, while non-partitioned tables sort directly by RowID.
Changes
Testing
Notes
No migration required. If any manifest lacks RowID stats, data evolution sorting falls back to the existing non-RowID path.