Repository navigation
[python] Avoid full-window conversion for first and last aggregates - #10016
Merged
Merged
Conversation
Scan Arrow chunks from the requested endpoint and convert only the selected value instead of materializing the full window as Python objects. Preserve null skipping, chunk boundaries, and nested and dictionary value semantics. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
JingsongLi
reviewed
Sep 21, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Requirement fit: SUPPORTED (triage: GO)\nImplementation: CLEAN\n\nThis removes window-size-dependent Python materialization from first and last aggregation while preserving endpoint and null semantics. I reviewed chunk traversal, dictionary values, nested values, all-null windows, and the memory regression coverage and found no actionable P0/P1/P2 issue in the current diff.
XiaoHongbo-Hope
pushed a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Window
firstandlastaggregates converted the entire window to Python objects before selecting one non-null value.Scan Arrow chunks from the requested endpoint and convert only the selected value, preserving null and value semantics.
Tests