Skip to content

[release] Fix Maven staging upload from reactor root - #10004

Merged
JingsongLi merged 1 commit into
apache:masterfrom
XiaoHongbo-Hope:codex/fix-maven-staging-noop
Sep 21, 2026
Merged

JingsongLi merged 1 commit into
apache:masterfrom
XiaoHongbo-Hope:codex/fix-maven-staging-noop

Conversation

@XiaoHongbo-Hope

Copy link
Copy Markdown
Contributor

The Maven release staging script can silently upload nothing when it is run from Paimon's multi-module repository root. The Nexus staging plugin defers a direct CLI invocation to the last reactor project, but that project is skipped in this invocation, so Maven reports BUILD SUCCESS without connecting to Nexus or creating a staging repository.

Add Maven's -N option so the root project is the only reactor project and deploy-staged-repository executes exactly once. All existing command overrides and staging safety settings remain unchanged.

The regression test uses fake Maven and GPG executables. It verifies one non-recursive staging invocation, the configurable arguments, and the existing close/release/failure behavior without contacting Nexus, uploading artifacts, or signing files.

Validation:

  • python3.11 -m unittest tools.ci.test_deploy_maven_repository
  • python3.11 -m unittest discover -s tools/ci -p 'test_*.py'
  • bash -n tools/releasing/deploy_maven_repository.sh
  • git diff --check

@XiaoHongbo-Hope
XiaoHongbo-Hope marked this pull request as ready for review September 20, 2026 09:22

@JingsongLi JingsongLi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirement fit: SUPPORTED (triage: GO)\nImplementation: CLEAN\n\nThis prevents a dangerous release false success where the staging script reports success but uploads nothing. The non-recursive Maven invocation executes the Nexus goal once at the reactor root, and the fake Maven/GPG tests retain close, release, override, and failure behavior without external side effects. No actionable P0/P1/P2 issue found.

@JingsongLi
JingsongLi merged commit 1eebeda into apache:master Sep 21, 2026
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants