cmake: normalize .config on reconfigure - #19693
Open
raiden00pl wants to merge 1 commit into
Open
Conversation
jerpelea
previously approved these changes
Aug 5, 2026
raiden00pl
force-pushed
the
cmake-config-normalise
branch
from
August 5, 2026 08:36
019f54c to
09a1e4b
Compare
github-actions
Bot
added
Area: Build system
Size: XS
|
xiaoxiang781216
previously approved these changes
Aug 5, 2026
raiden00pl
force-pushed
the
cmake-config-normalise
branch
from
August 6, 2026 06:45
09a1e4b to
219b1f0
Compare
github-actions
Bot
added
Size: S
raiden00pl
force-pushed
the
cmake-config-normalise
branch
from
August 6, 2026 11:54
219b1f0 to
c74a5f0
Compare
olddefconfig only ran when .config was generated from the defconfig, so changes applied to an existing .config (e.g. with kconfig-tweak) never got their dependent defaults. Run olddefconfig on reconfigure as well, as the Make flow does on every build. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
raiden00pl
force-pushed
the
cmake-config-normalise
branch
from
August 6, 2026 16:09
c74a5f0 to
9d19e26
Compare
xiaoxiang781216
approved these changes
Aug 7, 2026
Contributor
|
@michael-membrowse could you look at why MemBrowse report failure? |
|
@xiaoxiang781216 thank you for pointing it out. works now |
xiaoxiang781216
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
olddefconfig only ran when .config was generated from the defconfig, so changes applied to an existing .config (e.g. with kconfig-tweak) never got their dependent defaults. Run olddefconfig on reconfigure as well, as the Make flow does on every build.
Impact
align cmake with make
Testing
update cmake generated config with kconfig-tweak