JSF: support custom component new URN namespace - #9625
Open
NicolaIsotta wants to merge 1 commit into
Open
NicolaIsotta wants to merge 1 commit into
NicolaIsotta wants to merge 1 commit into
Conversation
NicolaIsotta
marked this pull request as draft
September 19, 2026 13:36
Contributor
Author
|
I'm marking thias as draft since the fix it's gonna be not as simple as I thought - Faces 3 has the jakarta package, but still relies on the old namespace: the new namespaces were introduced with Faces 4. |
Update the JSF custom component wizard and metamodel to use "jakarta.faces.component" as the default tag namespace on Jakarta Faces projects while preserving "http://xmlns.jcp.org/jsf/component" for legacy JSF versions (3.0 and previous).
NicolaIsotta
force-pushed
the
jsf-component-ns
branch
from
September 21, 2026 06:39
fb85a6d to
0ca2833
Compare
NicolaIsotta
marked this pull request as ready for review
September 21, 2026 07:47
Contributor
Author
|
Fixed now - we can get the default name space directly from the annotation, pretty elegant IMHO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the JSF custom component wizard and metamodel to use "jakarta.faces.component" as the default tag namespace on Jakarta Faces projects while preserving "http://xmlns.jcp.org/jsf/component" for legacy JSF versions (3.0 and previous).
For reference:
https://jakarta.ee/specifications/faces/2.3/apidocs/javax/faces/component/facescomponent#namespace--
https://jakarta.ee/specifications/faces/3.0/apidocs/jakarta/faces/component/facescomponent#namespace()
https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/component/facescomponent#namespace()
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)