GH-2196: Avoid warning for same-session repository fall-through

[efegokdemir]

DefaultUpdateCheckManager now tracks artifact not-found markers written during the current RepositorySystemSession. When a sibling repository later provides the artifact, a marker written in the same session is still expired but logged at DEBUG. A marker from an earlier session continues to produce a warning.

Fixes #2196

Testing

• mvn -pl maven-resolver-impl -am -Dtest=DefaultUpdateCheckManagerTest -Dsurefire.failIfNoSpecifiedTests=false test — 38 tests passed
• mvn -pl maven-resolver-impl -am test — 585 tests passed, 5 skipped
• mvn -pl maven-resolver-impl -am spotless:check — passed
• git diff --check — passed

---

• I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
• I hereby declare that I have filed an Apache Individual Contributor License Agreement

[gnodet-bot]

LGTM. No issues found.

Session-scoped ConcurrentHashMap correctly tracks same-session not-found markers using the established Keys.of(new Object(){}) pattern. Thread safety is sound — computeIfAbsent ensures single map creation, and ConcurrentHashMap handles concurrent put/containsKey. Pre-fix test validation confirmed the same-session test fails on master and passes with the fix. The metadata path is unaffected (it never calls getStaleSiblingNotFounds).

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open findings

• Reassigning System.err is a JVM-global change and can make the test suite flaky when tests run… · New
• Asserting on the literal substring \"WARN\" is brittle: it assumes a particular logging… · New
• This uses a Map<String, Boolean> as a set, which forces unchecked casts and adds unnecessary… · New

What changed in this PR

Adds session-aware tracking of artifact “not found” markers to reduce noisy warnings during same-session repository fall-through, while retaining warnings for stale markers from previous sessions.

Changes:

• Track “not found” markers written within the current RepositorySystemSession and downgrade same-session fall-through logging to DEBUG.
• Update stale sibling not-found detection to differentiate current vs previous session markers.
• Add tests validating WARN vs non-WARN behavior across sessions by capturing logger output.

File	Description
maven-resolver-impl/​src/​main/​java/​org/​eclipse/​aether/​internal/​impl/​DefaultUpdateCheckManager.java	Adds per-session tracking for not-found markers and adjusts stale-marker logging behavior.
maven-resolver-impl/​src/​test/​java/​org/​eclipse/​aether/​internal/​impl/​DefaultUpdateCheckManagerTest.java	Adds tests to assert logging behavior for same-session vs previous-session sibling not-found markers.

🧠 Review effort: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[cstamas]

@efegokdemir By the sheer amount of your contributions, it may be worth to file ICLA
https://www.apache.org/licenses/contributor-agreements.html

[efegokdemir]

Thanks for the heads-up, Tamás! I've signed the ICLA and emailed it to Apache. Appreciate the suggestion!