KYLIN-6092 Add polymorphic type validator for secure JSON deserialization - #2354
Open
jlfsdtc wants to merge 4 commits into
Open
KYLIN-6092 Add polymorphic type validator for secure JSON deserialization#2354jlfsdtc wants to merge 4 commits into
jlfsdtc wants to merge 4 commits into
Conversation
…e during JSON deserialization Event, SegmentRange and BroadcastEventReadyNotifier use @JsonTypeInfo(Id.CLASS), which lets an attacker-supplied @Class id load arbitrary classes (deserialization gadget attack). Set a BasicPolymorphicTypeValidator that only allows org.apache.kylin.* subtypes on the JsonUtil mappers and on the Spring HTTP converter ObjectMapper in AppConfig. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Change looks promising. https://github.com/search?q=repo%3Aapache%2Fkylin+new+ObjectMapper&type=code Not all of the mappers in the search results are test cases. |
- BaseSchedulerTest: stop the scheduler and wait for JobWorker threads to unwind before cleanup, so a lingering worker does not steal driver memory from the next test's baseline (ResourceAcquirer's semaphore is static). - KylinConfigBaseTest: compare ext jar paths order-insensitively. - .gitignore: exclude UT temp files and generated query result artifacts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
You right. I will replace |
Route JSON reads/writes through JsonUtil so they inherit the shared polymorphic type validator instead of using raw ObjectMapper instances. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Broaden the .gitignore patterns to cover all *.sql.json/*.sql.schema under kylin-it test resources and remove the ones already tracked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Draft: UT cache files will be modified subsequently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event, SegmentRange and BroadcastEventReadyNotifier use @JsonTypeInfo(Id.CLASS), which lets an attacker-supplied @Class id load arbitrary classes (deserialization gadget attack). Set a BasicPolymorphicTypeValidator that only allows org.apache.kylin.* subtypes on the JsonUtil mappers and on the Spring HTTP converter ObjectMapper in AppConfig.