OAK-12378: Avoid allocating a new Comparator on every PropertyTemplate.compareTo() call - #3095
Merged
Merged
Conversation
…e.compareTo() call
smiroslav
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OAK-12378:
PropertyTemplate.compareTo()builds a freshComparatorchain (3 objects, viacomparingInt()+ twothenComparing()calls) on every invocation instead of reusing a single instance. This method runs O(n log n) times when sorting templates during node writes, and is especially hot during compaction.A Java Flight Recorder analysis found this allocation site responsible for ~81% of sampled allocation weight (~705 GB of allocation pressure) — by far the largest source in the recording. During compaction on a 1.2 GB heap this contributed to significant GC stress: 77 old-generation collections consuming 41.2s within a 300s window (13.7%), plus 200 evacuation failures and 4 concurrent mode failures indicating heap exhaustion.
Summary
PropertyTemplate.compareTo()allocated a newComparatorchain on every call. Hoist it into a static final field so it's built once.Test plan
PropertyTemplatetests covercompareTo().