Conversation
Combine the None-validation and str-conversion loops over dict.items() into a single pass, and rename the `dict` parameter to `d` to stop shadowing the builtin. Fixes apache#3987
ebyhr
approved these changes
Sep 17, 2026
ebyhr
left a comment
ebyhr
left a comment
Member
There was a problem hiding this comment.
I think this is more of a cosmetic code quality fix than a meaningful perf win, but still worth having.
Fokko
approved these changes
Sep 18, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Nice one @ArulJerald Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transform_dict_value_to_striterated overdict.items()twice: once tovalidate no value is
None, once more in a dict comprehension to convertvalues to strings. Combined into a single pass.
dicttodso it no longer shadows thebuiltin type.
Closes #3987
Test plan
uv run pytest tests/test_types.py -k transform_dict_value_to_strruff check pyiceberg/types.py