[server] fix zk notification purge race#3752
Open
gyang94 wants to merge 2 commits into
Open
Conversation
Member
There was a problem hiding this comment.
@gyang94 Thank you, fix is sound, some ideas about the test below, PTAL
The test passes even with the fix reverted because our test config has the root logger OFF, so the appender never gets the ERROR and noneMatch on an empty list is always true.
So a couple of suggestions:
- mockito isn't really needed: the handler runs before the purge and they share the children list, so a handler that deletes the notification node gives the purge a stale list, the exact race from the issue.
a sketch:
TestingNotificationHandler handler =
new TestingNotificationHandler() {
@Override
public void processNotification(byte[] notification) {
super.processNotification(notification);
deleteAllNotificationNodes(); // purge now sees a stale list
}
};
- with root OFF the appender only works through its own LoggerConfig, smth like this:
LoggerContext ctx = (LoggerContext) LogManager.getContext(false);
Configuration cfg = ctx.getConfiguration();
LoggerConfig lc = new LoggerConfig(ZkNodeChangeNotificationWatcher.class.getName(), Level.DEBUG, false);
lc.addAppender(appender, Level.DEBUG, null);
cfg.addLogger(lc.getName(), lc);
ctx.updateLoggers();and assert the debug message is present rather than the error absent, so it can't go vacuous again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3753
Brief change log
empty check for zk stats
Tests
API and Format
Documentation