FINERACT-2773: Add template API for Asset externalization product attributes - #6295
Open
adamsaghy wants to merge 1 commit into
Open
FINERACT-2773: Add template API for Asset externalization product attributes#6295adamsaghy wants to merge 1 commit into
adamsaghy wants to merge 1 commit into
Conversation
Comment on lines
+65
to
+66
| Arrays.stream(implementingClass.getEnumConstants()).map(ExternalAssetOwnerLoanProductAttribute.class::cast) | ||
| .forEach(attribute -> addAttributeValues(result, attribute)); |
Contributor
There was a problem hiding this comment.
None of getAttributeKey, getAttributeValues or isMultiValue actually looks at the
constant it's called on, they all return the same type-level data. So looping over the enum
constants just appends the same entry twice, and the endpoint returns SETTLEMENT_MODEL
duplicated
| */ | ||
|
|
||
| @Data | ||
| @Getter |
Contributor
There was a problem hiding this comment.
@Data already includes @Getter
oleksii-novikov-onix
suggested changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.