Skip to content

FINERACT-2455: Rework WorkingCapitalLoanAddChargeBusinessEvent - #6294

Open
Cocoa-Puffs wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455-add-working-capital-loan-charge-business-event
Open

FINERACT-2455: Rework WorkingCapitalLoanAddChargeBusinessEvent#6294
Cocoa-Puffs wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455-add-working-capital-loan-charge-business-event

Conversation

@Cocoa-Puffs

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Cocoa-Puffs
Cocoa-Puffs force-pushed the FINERACT-2455-add-working-capital-loan-charge-business-event branch from b8a205c to 7434ac7 Compare August 19, 2026 12:45
@Cocoa-Puffs Cocoa-Puffs changed the title FINERACT-2455: Rename WorkingCapitalLoanChargeBusinessEvent FINERACT-2455: Rework WorkingCapitalLoanChargeBusinessEvent Aug 19, 2026
@Cocoa-Puffs Cocoa-Puffs changed the title FINERACT-2455: Rework WorkingCapitalLoanChargeBusinessEvent FINERACT-2455: Rework WorkingCapitalLoanAddChargeBusinessEvent Aug 19, 2026

@galovics galovics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the collapse is safe - WorkingCapitalLoanChargeBusinessEvent had exactly one subclass, no reflection-based lookup by the abstract type (the classgraph scan used for external event config explicitly filters out abstract classes), and no listener anywhere references the removed Pre event. No Liquibase migration needed since the concrete event's TYPE string is unchanged - correctly none added.

One correction on the reasoning from the earlier pass, for the record: the abstract class wasn't a leftover from some other sibling event being removed - git history shows it was introduced together with the single subclass and never had a second one, so this was premature abstraction from day one rather than cleanup after a removal. Doesn't change the verdict, just wanted to flag it so the "sibling removed elsewhere" framing doesn't stick around as the reason in anyone's memory.

One nit in the new test: FeignWorkingCapitalLoanAddChargeBusinessEventTest collects createdProductIds in a list but the @AfterAll only clears it, never actually deletes the products - every run leaks one. BatchWorkingCapitalLoanIntegrationTest has the cleanup pattern to copy from.

Recommendation: APPROVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants