FINERACT-2762: Client Approval/Activation Fails for Branch Manager Despite Having Required Permissions - #6282
Open
rymghosn wants to merge 1 commit into
Conversation
…ts direct endpoint A user holding only the "<TASK>_CHECKER" permission for a maker-checker task (no base permission) was refused outright when calling the action's normal endpoint, even when a matching maker submission was already awaiting their approval. This forced such users through the separate checker-inbox approval endpoint for every case, with no fallback when that endpoint wasn't reachable. Checker-only calls now look up the pending command for the same action/entity/resource and auto-approve it if one exists; if none exists, the call is refused with the existing permission-denied response, unchanged. Maker flows and users holding both the base and checker permission are unaffected.
rymghosn
force-pushed
the
port/CBS-511-checker-only-auto-approve
branch
from
August 18, 2026 13:54
e6437af to
8ec1cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a maker-checker-enabled task, a user holding only the _CHECKER permission (no base permission) was refused with a generic "not
authorized" response when calling the entity's normal action endpoint — even when a matching maker submission was already awaiting exactly this
user's approval. The only way such a user could act was through the separate checker-inbox approval endpoint (POST
.../commands/{id}?command=approve); there was no fallback when a checker-only user instead called the same action endpoint a maker would use
(e.g. POST /clients/{clientId}?command=activate), which is the natural path from the entity's own screen.
PortfolioCommandSourceWritePlatformServiceImpl#logCommandSource now checks, for a checker-only caller, whether a pending CommandSource exists for
the same action/entity/resource, and approves it directly if found. If none exists, the call is refused with the existing permission-denied
response, unchanged. Maker flows and users holding both the base and checker permission are unaffected.
PR:(https://issues.apache.org/jira/browse/FINERACT-2762)