FINERACT-2455: Add remaining wc loan business events - #6276
Conversation
a4a95af to
98bfd6c
Compare
|
c4824bb to
e98a115
Compare
e98a115 to
13d0594
Compare
galovics
left a comment
There was a problem hiding this comment.
The Liquibase changeset shape itself is fine - new file, correct preConditions guard, matches the module's established pattern. The problem is scope collision and one migration-correctness issue.
1. This collides directly with #6300. Both PRs delete WorkingCapitalLoanChargeAdjustmentPreBusinessEvent and rename the Post event, on the same JIRA ticket - but they pick two different names for the successor (WorkingCapitalLoanChargeAdjustmentBusinessEvent here vs. WorkingCapitalLoanChargeAdjustmentTransactionBusinessEvent in #6300). Whichever lands second either conflicts outright or leaves a stale, unbacked config row plus a double rename visible to anyone consuming the event type externally. #6300's name is also the one that matches the local convention - every sibling in this package is WorkingCapitalLoan<X>TransactionBusinessEvent. Can you two sync on this and let one PR own the rename?
2. The migration loses the enabled flag for existing tenants. wcl-0070-1 does a plain INSERT for the renamed event with enabled=false, rather than an UPDATE that renames the row in place. Any tenant that had WorkingCapitalLoanChargeAdjustmentPostBusinessEvent turned on silently stops receiving it after upgrade, with no signal. #6300 handles the identical rename correctly with an in-place UPDATE ... WHERE type = '...Post...'. Please use that pattern here too.
Smaller: no test covers the one actual behavioral change in this PR (the rename) - the four new tests all cover events that already existed on develop before this PR. And the removal of the pre-event notification call isn't mentioned in the PR description, though I confirmed there's no registered listener for it so it's safe.
Recommendation: CHANGES_REQUESTED
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.